Do not add max_blocks as a bucket in linear bucketing with cpa #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mswiniarsk
requested review from
kzawora-intel,
xuechendi and
adobrzyn
as code owners
mswiniarsk
force-pushed
the
mswiniarsk/dont_add_max_buckets_in_linear_with_cpa
branch
from
036c660 to
1bd1702
Compare
adobrzyn
approved these changes
Sep 2, 2025
|
Resolved with: #126. I think we can close it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bucket is not needed and adding it ends with an error:
Worker failed with error 'could not broadcast input array from shape (4607,) into shape (2304,)'